Feature #183, added screenshots to install and uninstall instructions#225
Merged
georgemccabe merged 13 commits intorelease_v1.1from Jul 6, 2023
Merged
Feature #183, added screenshots to install and uninstall instructions#225georgemccabe merged 13 commits intorelease_v1.1from
georgemccabe merged 13 commits intorelease_v1.1from
Conversation
hahnd
requested changes
Jul 5, 2023
hahnd
requested changes
Jul 5, 2023
hahnd
approved these changes
Jul 5, 2023
fossell
approved these changes
Jul 6, 2023
Collaborator
fossell
left a comment
There was a problem hiding this comment.
The screen shots are a great addition, the text overlay directions are clear and helpful. Looks good!
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183
Expected Differences
Pull Request Testing
Reviewed documentation updates
Review documentation updates and screenshots. Rendered content can be found here:
https://wrfcloud.readthedocs.io/en/feature_183_screenshots/Users_Guide/installation.html
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
Please complete this pull request review by 7/10/2023.
Pull Request Checklist
Select: Reviewer(s)
Select: Project
Select: Milestone as the version that will include these changes
Select: Development to link to the original development issue.