Skip to content

Feature #183, added screenshots to install and uninstall instructions#225

Merged
georgemccabe merged 13 commits intorelease_v1.1from
feature_183_screenshots
Jul 6, 2023
Merged

Feature #183, added screenshots to install and uninstall instructions#225
georgemccabe merged 13 commits intorelease_v1.1from
feature_183_screenshots

Conversation

@georgemccabe
Copy link
Collaborator

Closes #183

Expected Differences

  • Do these changes modify the system output in any way? [No]

Pull Request Testing

  • Describe testing already performed for these changes:

Reviewed documentation updates

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review documentation updates and screenshots. Rendered content can be found here:
https://wrfcloud.readthedocs.io/en/feature_183_screenshots/Users_Guide/installation.html

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 7/10/2023.

Pull Request Checklist

  • Review the source issue metadata (labels, project, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Project
    Select: Milestone as the version that will include these changes
    Select: Development to link to the original development issue.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the Version 1.1 milestone Jul 5, 2023
@georgemccabe georgemccabe requested review from fossell and hahnd July 5, 2023 19:03
@georgemccabe georgemccabe requested a review from hahnd July 5, 2023 20:55
@georgemccabe georgemccabe requested a review from hahnd July 5, 2023 20:59
@fossell fossell self-assigned this Jul 6, 2023
Copy link
Collaborator

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen shots are a great addition, the text overlay directions are clear and helpful. Looks good!

@georgemccabe georgemccabe merged commit e982258 into release_v1.1 Jul 6, 2023
@georgemccabe georgemccabe deleted the feature_183_screenshots branch July 6, 2023 18:32
@georgemccabe georgemccabe linked an issue Jul 6, 2023 that may be closed by this pull request
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add screen shots to installation section of UG

3 participants