Optional to turn off chunk caching by Reductionist#321
Merged
valeriupredoi merged 8 commits intomainfrom Mar 31, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 93.55% 93.59% +0.03%
==========================================
Files 7 7
Lines 667 671 +4
==========================================
+ Hits 624 628 +4
Misses 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@maxstack this works, fine, cheers muchly for the new option! Do you mind having a quick look at it see if you can spot any issues, before I merge, please, bud? 🍻 |
Collaborator
Author
|
merging now (docs fail coz of some scipy online resource is offline temporarily) so that @varsiha-sothilingam can test right away see if she is still getting the 503s from yesterday 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @maxstack and @varsiha-sothilingam this is the Client end of the implementation of a flag that turns off chunk caching (for tests, nightly tests, or other used cases when we don't want to write chunk caches). Max, at the moment I am getting this:
I'd assume since the option is on a branch and not yet deployed on Reductionist v2?🍻Reductionist container v0.13 has it implemented now!
Before you get started
Checklist