Skip to content

Conversation

@kmuehlbauer
Copy link
Collaborator

@kmuehlbauer kmuehlbauer commented Oct 22, 2025

Description

As described in #89 we want to add more decompression filters. LZF is used within the xarray testsuite and by implementing this will fix the xarray testsuite for the H5NetCDF related tests.

This also serves as a blueprint for other filters (blosc, lzma etc.).

Before you get started

Checklist

  • This pull request has a descriptive title and labels
  • This pull request has a minimal description (most was discussed in the issue, but a two-liner description is still desirable)
  • Unit tests have been added (if codecov test fails)
  • Any changed dependencies have been added or removed correctly (if need be)
  • If you are working on the documentation, please ensure the current build passes
  • All tests pass

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.13%. Comparing base (29b2b59) to head (34e4a57).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pyfive/btree.py 62.50% 2 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (72.72%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   74.03%   74.13%   +0.09%     
==========================================
  Files          11       11              
  Lines        2596     2606      +10     
  Branches      406      408       +2     
==========================================
+ Hits         1922     1932      +10     
- Misses        565      566       +1     
+ Partials      109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmaranville
Copy link
Collaborator

It is impressive how straightforward this is compared to compiling a dynamic link library and loading it at runtime, as is needed when using plugins with the C library.

@kmuehlbauer
Copy link
Collaborator Author

kmuehlbauer commented Oct 22, 2025

@bmaranville I really thought, can it be that easy?, by looking at the gzip above.

@valeriupredoi
Copy link
Collaborator

the DLL is still there, but conda-forge compiled packages are the stuff of dreams 😁

Copy link
Collaborator

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spiffy, and with very many thanks as ever, @kmuehlbauer 🍺 @bnlawrence wanna have a final look and merge, please? 🍺

Copy link
Collaborator

@bnlawrence bnlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!!!

@bnlawrence bnlawrence merged commit bcb93ed into NCAS-CMS:main Oct 27, 2025
6 of 7 checks passed
@kmuehlbauer kmuehlbauer deleted the lzf-filter branch October 27, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants