-
Notifications
You must be signed in to change notification settings - Fork 24
add lzf decompress filter #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (72.72%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 74.03% 74.13% +0.09%
==========================================
Files 11 11
Lines 2596 2606 +10
Branches 406 408 +2
==========================================
+ Hits 1922 1932 +10
- Misses 565 566 +1
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It is impressive how straightforward this is compared to compiling a dynamic link library and loading it at runtime, as is needed when using plugins with the C library. |
|
@bmaranville I really thought, can it be that easy?, by looking at the gzip above. |
|
the DLL is still there, but conda-forge compiled packages are the stuff of dreams 😁 |
valeriupredoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spiffy, and with very many thanks as ever, @kmuehlbauer 🍺 @bnlawrence wanna have a final look and merge, please? 🍺
bnlawrence
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!!!
Description
As described in #89 we want to add more decompression filters. LZF is used within the xarray testsuite and by implementing this will fix the xarray testsuite for the H5NetCDF related tests.
This also serves as a blueprint for other filters (blosc, lzma etc.).
Before you get started
Checklist