Use taxon specific flag to make only_taxa optional for non-taxon-specific terms #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
changed the title
gaurav
added a commit
to TranslatorSRI/babel-validation
that referenced
this pull request
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to figure out how to query for
taxa == [], so instead I'm going to add ataxon_specificflag (NCATSTranslator/Babel#601) so that we can use it to ensure that our only_taxa queries are effectivelytaxa = only_taxa OR NOT taxon_specificso that non-taxon-specific concepts are still included.BREAKING: this NameRes will NOT work with a version of the database that is before Babel 2025nov4 from Babel 1.14.