Fix issue #113 #117
Merged
Fix issue #113 #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, get_info_content() expects canonical_nonan to not be empty, and will throw an exception if it is. This change moves it into the code that only runs if canonical_nonan is not empty.
1. We now impose a minimum of one CURIE as input to
/get_normalized_nodes.
2. This means that the only way in which we can get {} as a response is
if there was an error in processing. We now report this to the user
as an HTTP 500 error.
PhillipsOwen
previously requested changes
Jan 28, 2022
Contributor
PhillipsOwen
left a comment
PhillipsOwen
left a comment
There was a problem hiding this comment.
raised exceptions would benefit from more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for #113 -- a query containing only unresolvable curies will receive an empty response. This was happening because of two different reasons:
get_info_content()would throw an exception if given an empty list of canonical IDs. I moved the function call so that it would not be called with an empty list, and additionally modified the function so that it would return an empty dictionary if somebody did call it with an empty list from elsewhere.get_normalized_nodes()would return{}if an exception was thrown inside much of the function. I've added checks to the GET and POST endpoints so that:get_normalized_nodes()returns{}This PR adds a test for queries without any resolvable CURIEs and updated the test for queries without any CURIEs at all.
Also fixes a minor typo in the README file.