-
Notifications
You must be signed in to change notification settings - Fork 8
Adds the loading of the info-content data #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cbizon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where you are getting the ic out of redis?
When we do get it out, we may have a case where both conflated entities have their own ic, in which case we should choose the minimum one.
Do you really want to set all the databases to 0 in the config?
this part just gets the data into redis. i have not worked on getting it out of redis for the website. my idea is that we get the data loaded over the weekend and then work on pulling it out for the website monday. all the redis caches use db 0. presumably there is only 1 db per redis instance. |
|
Connections, and redis setup look good. For local testing maybe having different db (0-6) on the default config might be a good idea (since the default config refers to a single redis instance ) |
YaphetKG
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually tests redis yaml is changed to refer to db- 0 . That should be fine
this PR adds the loading of a new cache for the information content data.