Skip to content

Conversation

@PhillipsOwen
Copy link
Contributor

this PR adds the loading of a new cache for the information content data.

Copy link
Collaborator

@cbizon cbizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where you are getting the ic out of redis?

When we do get it out, we may have a case where both conflated entities have their own ic, in which case we should choose the minimum one.

Do you really want to set all the databases to 0 in the config?

@PhillipsOwen
Copy link
Contributor Author

PhillipsOwen commented Nov 5, 2021

I don't see where you are getting the ic out of redis?

When we do get it out, we may have a case where both conflated entities have their own ic, in which case we should choose the minimum one.

Do you really want to set all the databases to 0 in the config?

this part just gets the data into redis. i have not worked on getting it out of redis for the website. my idea is that we get the data loaded over the weekend and then work on pulling it out for the website monday.

all the redis caches use db 0. presumably there is only 1 db per redis instance.

@YaphetKG
Copy link
Contributor

YaphetKG commented Nov 5, 2021

Connections, and redis setup look good. For local testing maybe having different db (0-6) on the default config might be a good idea (since the default config refers to a single redis instance )

Copy link
Contributor

@YaphetKG YaphetKG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually tests redis yaml is changed to refer to db- 0 . That should be fine

@PhillipsOwen PhillipsOwen merged commit 4ba9a01 into master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants