dev 1757 add imemoryqueue to queue factory#13
Conversation
qqiao2024
changed the title
|
|
||
| class InMemoryQueueClient(QueueClient): | ||
|
|
||
| queues = {} |
There was a problem hiding this comment.
not sure if this is the best place for the holding and keeping track of queues, seems like ideally that responsibility would not be up to the client class. also, as an aside, if we used the the built in python Queue class instead of deque, the queues themselves would be threadsafe, although then we would probably want to guard the actual queues dictionary.
it also seems like we are changing the functionality of InMemoryQueueClient, as before a queue client could only connect to one queue. Did we need this added functionality somewhere else?
There was a problem hiding this comment.
Moved to QueueFactory,
changed to multiprocessing Queue.
This InMemoryQueue should only be used for testing.
| @@ -0,0 +1,53 @@ | |||
| import os | |||
There was a problem hiding this comment.
Did you use a git mv or did you delete the file and recreate it? It looks like it was recreated, so I would go back and restore the previous versions and them git mv to keep the history.
There was a problem hiding this comment.
Just tried. After I add an empty init.py, it will come back to this.
3 participants
No description provided.