Conversation
Add pre-commit and detect-secrets so it starts to automatically detect secrets for this code base. pre-commit requires cfgv. Use old cfgv version to work with py35 and py27
Add baseline file for detect-secrets for future reference.
asurinsaka
requested review from
ProfOak,
XukunXiangUChicago,
anmaxvl,
kulgan,
phillipjohnson,
philtom-ctds and
scintillating7
and removed request for
phillipjohnson
| To update the .secrets.baseline file run | ||
| ``` | ||
| detect-secrets scan --update .secrets.baseline | ||
| git add .secrets.baseline |
There was a problem hiding this comment.
Remove the git add line. Don't need it since this commit adds the file.
correct files based on Phil's comment
philtom-ctds
approved these changes
Jul 21, 2020
qqiao2024
force-pushed
the
feat/DEV-159-detect-secrets
branch
from
97fec4e to
c0a3052
Compare
philtom-ctds
approved these changes
Jul 27, 2020
scintillating7
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pre-commit and detect-secrets.