make elasticsearch network.host configurable

[xtruthx]

This PR fixes #219

[widhalmt]

Thanks for the PR!

I'm just wondering, should we use a single string for the variable or should we make the variable an array since the option in the file is an array, too?

I'm ok with your string variant, especially since using Jinja2 for an array would be much more complicated (like ifnotlast, then "," etc)

So, approved. Thanks, again.

[widhalmt]

Sorry, I had to change back to "Request changes". Could you please write a line about the new variable in the appropriate file in docs/?

[xtruthx]

Sorry, I had to change back to "Request changes". Could you please write a line about the new variable in the appropriate file in docs/?

I will avoid doiing duplicate work. This will be done within the PR for the documentation review. Pls accept the PR without additionl docs, anyway if you not set it the "legacy" default will take precedence.

[widhalmt]

Ah, ok. That's fine, of course. So - approved.

[xtruthx]

the fix of #217 conflicts :/

[lcndsmr]

Its just a renaming of variables, you should just replace the names and it should work. I can do it quickly if you want to?

[xtruthx]

Its just a renaming of variables, you should just replace the names and it should work. I can do it quickly if you want to?

thx, its already done.

[widhalmt]

Sorry, I have to revert my approval. I thought a lot about how the collection is proceeding and I'm afraid we have to face the fact that we aren't full time developers andtherefore we can be sure that we run into times where changes will have to wait for a long time. (You had to experience that for yourself). So the only way to not lose focus and have all neccessary steps done right away is to make changes atomic. Therefore I opened an issue to force documentation with every step: #234 .

So please add documentation for that variable with this PR.

[xtruthx]

Sorry, I have to revert my approval. I thought a lot about how the collection is proceeding and I'm afraid we have to face the fact that we aren't full time developers andtherefore we can be sure that we run into times where changes will have to wait for a long time. (You had to experience that for yourself). So the only way to not lose focus and have all neccessary steps done right away is to make changes atomic. Therefore I opened an issue to force documentation with every step: #234 .

So please add documentation for that variable with this PR.

I've add a description to the documenation.

[widhalmt]

Thank you! Approved.