Skip to content

Conversation

@widhalmt
Copy link
Member

@widhalmt widhalmt commented Sep 5, 2023

This will force Molecule to run Ansible Galaxy twice. Once for roles, once for collection.

fixes #254

@widhalmt widhalmt added bug Something isn't working dependencies Pull requests that update a dependency file labels Sep 5, 2023
@widhalmt widhalmt added this to the 1.0.0 milestone Sep 5, 2023
@widhalmt widhalmt self-assigned this Sep 5, 2023
@widhalmt
Copy link
Member Author

widhalmt commented Sep 5, 2023

I'm not convinced that this change is really neccessary. It seems like the behaviour is exactly the same. My interpretation for now: First it installs the collections, then it runs again for roles. Since the both runs don't know of each other, the second issues the warning. So, since it's working as expected I'm ok with both - merging or closing.

Tests seem to fail because of timeouts at Rocky Linux repos.

@afeefghannam89
Copy link
Member

@widhalmt where is the collections.yml file, I do not see it? Did I misunderstand the goal of this PR? Can you please clarify more?

@widhalmt
Copy link
Member Author

widhalmt commented Sep 5, 2023

Of course. I got the name wrong. 🤦🏽 I meant the requirements.yml in most Molecule scenarios.

@widhalmt widhalmt enabled auto-merge September 5, 2023 15:26
Copy link
Member

@afeefghannam89 afeefghannam89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ;)

@widhalmt widhalmt added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 5, 2023
@widhalmt widhalmt added this pull request to the merge queue Sep 5, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 5, 2023
@widhalmt widhalmt added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 6, 2023
@widhalmt widhalmt enabled auto-merge September 6, 2023 14:49
@widhalmt widhalmt added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 0c97d25 Sep 6, 2023
@widhalmt widhalmt deleted the fix/molecule-requirements-254 branch September 6, 2023 16:29
ivareri pushed a commit to ivareri/ansible-collection-elasticstack that referenced this pull request Jun 17, 2025
This will force Molecule to run Ansible Galaxy twice. Once for roles,
once for collection.

fixes NETWAYS#254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parts of requirements files are ignored

3 participants