Always run required checks #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have quite sophisticated rules when to run which Molecule checks. Unfortunately it's quite easy to have a PR or push where the full stack checks won't run. But since we require these checks, you can end up in a situation where you don't have check results but can't merge without those results. So I simplified the rules when to run these checks. fixes #300
tbauriedel
approved these changes
Jan 16, 2024
Contributor
tbauriedel
left a comment
tbauriedel
left a comment
There was a problem hiding this comment.
Pipeline seems legit.
Single point:
The pipelines are currently not only started for new PRs, but also for pushes in branches. I'm not familiar with your process, but if that's what you explicitly want, that's okay.
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
We have quite sophisticated rules when to run which Molecule checks. Unfortunately it's quite easy to have a PR or push where the full stack checks won't run. But since we require these checks, you can end up in a situation where you don't have check results but can't merge without those results. So I simplified the rules when to run these checks. fixes NETWAYS#300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have quite sophisticated rules when to run which Molecule checks. Unfortunately it's quite easy to have a PR or push where the full stack checks won't run. But since we require these checks, you can end up in a situation where you don't have check results but can't merge without those results.
So I simplified the rules when to run these checks.
fixes #300