Fix apt key handling2 #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
widhalmt
approved these changes
Feb 9, 2024
Member
widhalmt
left a comment
widhalmt
left a comment
There was a problem hiding this comment.
Worked in my tests. Thank you so much for your contribution!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
f/u to NETWAYS#306 Refactored key and sources list for debian based distros. Use current state of the art to include 3party repos. * avoid apt warning `W:https://artifacts.elastic.co/packages/8.x/apt/dists/stable/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details` * prepare for deb822 format: * > Entries MUST be added in the /etc/apt/sources.list.d directory using a shortened repository name * > A sources.list entry SHOULD have the signed-by option set. see: https://wiki.debian.org/DebianRepository/UseThirdParty PS: this time I have run the checks in question (sorry for my carelessness in the other PR): * https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-collection-elasticstack/actions/runs/7677838360 * https://github.com/Rosa-Luxemburgstiftung-Berlin/ansible-collection-elasticstack/actions/runs/7677869397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f/u to #306
Refactored key and sources list for debian based distros. Use current state of the art to include 3party repos.
W:https://artifacts.elastic.co/packages/8.x/apt/dists/stable/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for detailssee: https://wiki.debian.org/DebianRepository/UseThirdParty
PS: this time I have run the checks in question (sorry for my carelessness in the other PR):