Fix current problems with molecule checks #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Havin `become` only in tasks where needed might be good coding style but it breaks tests with Rocky Linux and might have other unpredicted side effects. So I'm removing it.
widhalmt
changed the title
become
tbauriedel
previously approved these changes
Jan 28, 2025
Contributor
tbauriedel
left a comment
tbauriedel
left a comment
There was a problem hiding this comment.
I am not familiar with that part of the collection in detail.
But the changes I can see look okay.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
afeefghannam89
approved these changes
Jan 31, 2025
Contributor
|
@afeefghannam89 |
Contributor
|
I have run the actions again. |
ivareri
pushed a commit
to ivareri/ansible-collection-elasticstack
that referenced
this pull request
Jun 17, 2025
There are two problems that both break tests. I try to solve them in a single PR because one would block merging the other. Both are "new problems" that arose through updates of tools being used. The checks worked in the past. * Having `become` only in tasks where needed might be good coding style but it breaks tests with Rocky Linux and might have other unpredicted side effects. So I'm removing it. * Starting `rsyslog` on Rocky Linux fails with "Timeout". There' no further information so I decided to replace it with reading journald instead of rsyslog. This might have been a move to make in the future anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems that both break tests. I try to solve them in a single PR because one would block merging the other. Both are "new problems" that arose through updates of tools being used. The checks worked in the past.
becomeonly in tasks where needed might be good coding style but it breaks tests with Rocky Linux and might have other unpredicted side effects. So I'm removing it.rsyslogon Rocky Linux fails with "Timeout". There' no further information so I decided to replace it with reading journald instead of rsyslog. This might have been a move to make in the future anyway.