Feature/enhance icingadb retention config #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocdaniel
reviewed
Jan 7, 2024
Member
mocdaniel
left a comment
mocdaniel
left a comment
There was a problem hiding this comment.
LGTM, did you mean to commit molecule/local-default/*, @mkayontour? I am not sure whether this is your local test environment or the 'general' one.
Member
Author
|
This is right, I added them that everyone can use the local-defaults to test and then afterwards run tests on the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the retention configuration parameters to the role.
Adds some tests in the build and via testinfra if the parameters are set in the file.
Adds documentation on every variable.
Adds changelog fragments
fixes #200