Skip to content

Fix module configuration task order #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fix module configuration task order #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9288121
changed order, to enable/disable modules before configuration.
mkayontour Jan 5, 2024
f9739f2
added changelog fragment #225
mkayontour Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/fix_change_order_of_module_tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- "Icingaweb2: Change order of module state and configuration tasks #225"
14 changes: 8 additions & 6 deletions roles/icingaweb2/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,7 @@
ansible.builtin.include_tasks: "manage_icingaweb_{{ icingaweb2_db.type }}_db.yml"
when: icingaweb2_db is defined

- name: Configure modules
ansible.builtin.include_tasks: "modules/{{ item.key }}.yml"
when: icingaweb2_modules is defined
loop: "{{ icingaweb2_modules | dict2items }}"

- name: Manage enabled/disabled modules
- name: Manage module states
ansible.builtin.file:
src: "{{ icingaweb2_config.global.module_path + '/' + item.key if item.value.enabled|bool == true else omit }}"
dest: "{{ icingaweb2_config_dir }}/enabledModules/{{ item.key }}"
Expand All @@ -43,6 +38,13 @@
force: yes
when: icingaweb2_modules is defined
loop: "{{ icingaweb2_modules | dict2items }}"
loop_control:
label: "Ensure {{ item.key }} is {{ 'enabled' if item.value.enabled|bool == true else 'disabled' }}"

- name: Configure modules
ansible.builtin.include_tasks: "modules/{{ item.key }}.yml"
when: icingaweb2_modules is defined
loop: "{{ icingaweb2_modules | dict2items }}"

# Many daemons fail before e.g. the resource is set up or the schema hasn't been migrated. This is a workaround.
- name: Manage enabled module daemons
Expand Down