This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Refactor End of Training #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no longer relevant
martialblog
force-pushed
the
refactor/end-of-training
branch
from
8ac08be to
79d4dbf
Compare
Member
Author
|
@htriem @mocdaniel Feedback is welcome |
theFeu
reviewed
Dec 1, 2022
Member
Author
|
Yes absolutely. It was just faster for the draft... |
- Add 'What have we learned?' section after CI - Move following slides into an optional "outlook" section
martialblog
force-pushed
the
refactor/end-of-training
branch
from
79d4dbf to
a2f4e2c
Compare
Member
Author
|
I restructured the directories |
Member
|
I like the changes, and with the 'chapter' logic adjusted I don't see anything left to do before merging, unless you got some more changes locally. |
Member
Author
|
Ready to Ship |
Member
Author
|
@htriem What do you think? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactores the End of the Training.
After the CI Topic there's now a "What have we learned" Section. These slides offer a chance to look back and internalize all the topics covered.
After the review, the trainer can decide how to move forward, with the "further features in git and gitlab" sections.
See #177