Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@htriem
Copy link
Contributor

@htriem htriem commented Dec 1, 2022

Fixes #153.

I don't think that's everything, I'm not too sure either what would be missing or where exactly you're looking for that replacement.

@htriem htriem requested a review from theFeu December 1, 2022 15:32
@martialblog
Copy link
Member

I think what @theFeu meant is that when you create a now Project in GitLab, you get some command suggestions i.e.

Push an existing Git repository

cd existing_repo
git remote rename origin old-origin
git remote add origin git@git.example.com/deleteme.git
git push -u origin --all
git push -u origin --tags

And we should add that in the slides. Right?

@theFeu
Copy link
Collaborator

theFeu commented Jan 12, 2023

The text from GitLab is:

cd existing_repo
git remote rename origin old-origin
git remote add origin git@git.example.com/deleteme.git
git push -u origin --all
git push -u origin --tags

What we want is

cd existing_repo
git remote add origin git@git.example.com/deleteme.git
git push -u origin --all
git push -u origin --tags

So the suggestion without the git remote rename origin old-origin

@martialblog
Copy link
Member

@theFeu I updated the slides. Can you have a look pleaze.

@theFeu
Copy link
Collaborator

theFeu commented Jan 16, 2023

This change only affects the handout and not the presentation - was this intentional?

@martialblog
Copy link
Member

I think since we have the push in the "Lab 7.3: Add the repository as remote origin"

@theFeu
Copy link
Collaborator

theFeu commented Jan 16, 2023

I don't really understand what you mean by that...
My original thought was to have this

cd existing_repo
git remote add origin git@git.example.com/deleteme.git
git push -u origin --all
git push -u origin --tags

In the slides to show the attendees

Right now the slide looks like this:

image

Or did you mean to only add that to the exercises pdf?

@martialblog martialblog force-pushed the use-gitlab-push-suggestions branch from 319d4b4 to 38de134 Compare January 17, 2023 12:14
@martialblog
Copy link
Member

@theFeu Changed as discussed. Hint, I removed the --tags push since it's in the lab 8.3

@martialblog martialblog self-assigned this Jan 17, 2023
@martialblog martialblog force-pushed the use-gitlab-push-suggestions branch from 38de134 to cc66999 Compare January 17, 2023 15:21
@martialblog
Copy link
Member

We good on this? I think this looks alright now

@martialblog martialblog changed the base branch from master to release/v3-0-0 January 23, 2023 14:38
@martialblog martialblog force-pushed the use-gitlab-push-suggestions branch from 52a0632 to 539ed69 Compare January 23, 2023 14:38
@martialblog martialblog merged commit f00ef55 into release/v3-0-0 Jan 23, 2023
@martialblog martialblog deleted the use-gitlab-push-suggestions branch January 23, 2023 15:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change the slide on connecting the repo with remote to correspond to the GitLab suggestions

5 participants