Skip to content

Conversation

@nole2701
Copy link
Collaborator

For phonetics editing:

  • There is no phonetics before editing and there is no phonetics after editing -> do nothing
  • There is no phonetics before editing and there is phonetics after editing -> save the new phonetics
  • There is phonetics before editing and there is no phonetics after editing -> ask user if they mean to delete phonetics
  • There is phonetics before editing and there is phonetics after editing -> if updated then save new, otherwise do nothing

pre-commit is commented out due to an issue with index.ts not updating after making a change to types in form.rs.

@netlify
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for dailp canceled.

Name Link
🔨 Latest commit dcfc7d3
🔍 Latest deploy log https://app.netlify.com/sites/dailp/deploys/681d07e02e20e00008882d8c

@GracefulLemming

This comment was marked as outdated.

Copy link
Contributor

@GracefulLemming GracefulLemming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approving, but we probably want to replace the checkmark and its associated providers with something harder to miss soon

@GracefulLemming GracefulLemming merged commit f882a47 into main May 8, 2025
5 checks passed
@GracefulLemming GracefulLemming deleted the add-phonetics branch May 8, 2025 20:14
alisony755 pushed a commit that referenced this pull request Nov 15, 2025
Phonetics Editing with warning for deleting phonetics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants