Merged
Conversation
Collaborator
Author
|
This PR is ready to be reviewed. Please take a look. |
iusztin
approved these changes
Mar 29, 2023
Member
iusztin
left a comment
iusztin
left a comment
There was a problem hiding this comment.
Thank you :) I could run Invoker on CBK after using the change from this PR like:
diff --git a/Gemfile.local b/Gemfile.local
index 4d54b24ed..561c99f1b 100644
--- a/Gemfile.local
+++ b/Gemfile.local
@@ -4,3 +4,4 @@ source 'https://rubygems.org'
# server launcher
gem 'invoker'
+gem 'http-parser-lite', git: 'https://github.com/NEWROPE/http-parser-lite', ref: '516844c74a1e69979f45d5a95a4494256081e921'
LGTM! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve performance and reduce costs we decided to upgrade from Ruby v2 to Ruby v3 on the CBK project. CBK project is using the invoker gem, which is a bit old and depends on http-parser-lite. Unfortunately,
http-parser-liteis pretty old too, and is not compatible with Ruby v3 as is. There is an issue with executable import.See the investigation on Slack: https://newrope.slack.com/archives/C02S08WDQ/p1679976577729379?thread_ts=1679297062.851219&cid=C02S08WDQ.