feat(img): tuned image loading & added fallbacks#1192
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
* adds base64 loading * patches loaders * misc component fixes for images
lgtmrobo
reviewed
Apr 12, 2023
Contributor
lgtmrobo
left a comment
lgtmrobo
left a comment
There was a problem hiding this comment.
Overall looks good, will be excited to see the blur image in use in more places. This def needs some testing though since it touches a lot of pages, but no major red flags from a first pass
| currentNftsDescriptionsVisible: true, | ||
| currentLayoutType: ProfileLayoutType.Default, | ||
| searchQuery: null, | ||
| searchQuery: '', |
Contributor
There was a problem hiding this comment.
Did you test this one? It may cause issues with the search, but not 100% sure
Contributor
Author
There was a problem hiding this comment.
I did test it 👍
This resolves a react/html bug complaining about the inputs being null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
utils/format(The majority of this PR's file changes)Ex:
https://user-images.githubusercontent.com/19197856/231501792-cc543c72-0223-4b5b-8d83-755e1606a44f.mov
Associated JIRA task link
Routes affected by changes
example: '/app/list'
/*All routesRoundedCornerMedia.tsx&BlurImage.tsxcomponents and their associated utils atlib/image/loader.ts&utils/image.Checklist before requesting a review
Describe your self-review process (if applicable):
Include the added doppler env variables here (If applicable):
Prior Work
If this is a follow-up PR to existing work, link the relevant PR(s) here (or N/A if not a follow-up)