Skip to content

Fix/nft 1964#1214

Merged
lgtmrobo merged 17 commits intomainfrom
fix/NFT-1964
Apr 13, 2023
Merged

Fix/nft 1964#1214
lgtmrobo merged 17 commits intomainfrom
fix/NFT-1964

Conversation

@lgtmrobo
Copy link
Copy Markdown
Contributor

Describe your changes

  • fixes likes being called for each card
  • used array input for collections

Associated JIRA task link

Routes affected by changes

example: '/app/list'

/profileURI
/app/discover/collections
/app/discover/nfts
/app/discover/profiles

Checklist before requesting a review

  • I have performed a self-review of my code

    Describe your self-review process (if applicable):

     - tested to make sure all functionality is there
    
  • I have added component tests for this work
  • I have added e2e tests for this work
  • I have properly gated the features with a doppler env variable:
    • updated sandbox doppler config
    • updated staging doppler config
    • updated production doppler config

    Include the added doppler env variables here (If applicable):

       -
    

Prior Work

If this is a follow-up PR to existing work, link the relevant PR(s) here (or N/A if not a follow-up)

  • Link(s) to Prior Work:

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
production-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 3:46pm
sandbox-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 3:46pm
staging-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 3:46pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Apr 13, 2023 3:46pm

Copy link
Copy Markdown
Contributor

@ryolambert ryolambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Added some comments, but nothing that needs to fixed in this PR.

@lgtmrobo
Copy link
Copy Markdown
Contributor Author

@ryolambert i fixed them here anyway 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants