HPv3: Fixes, Pixel Perfect, Responsive by aglovlyuk · Pull Request #1232 · NFT-com/interface

aglovlyuk · 2023-04-18T20:53:45Z

Describe your changes

Pixel Perfect
Responsive fixes

Associated JIRA task link

NFT-1873

vercel · 2023-04-18T20:53:48Z

@aglovlyuk is attempting to deploy a commit to the NFT-com Team on Vercel.

To accomplish this, @aglovlyuk needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

# Conflicts: # components/modules/HomePage/DiscoverCollections.tsx # components/modules/HomePage/HeroSection.tsx # components/modules/HomePage/SocialSection.tsx # components/modules/HomePage/WhatWeCanDo.tsx # pages/index.tsx

vercel · 2023-04-18T21:55:53Z

@dimamankov is attempting to deploy a commit to the NFT-com Team on Vercel.

To accomplish this, @dimamankov needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

lgtmrobo

Please see comments, footer changes need to be gated until new homepage v3 goes out

footer from your PR:

Footer on Live site:

lgtmrobo · 2023-04-18T22:38:44Z

pages/index.tsx


      // Marquees
-      gsap
-        .timeline({


Does removing this affect things on the current homepage? Should these changes be gated?

We have moved old HP to another file HomePageV2.tsx'. Changes have been gated.

components/elements/Footer/FooterLarge.tsx

vercel · 2023-04-18T23:02:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
production-interface	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2023 11:57pm
sandbox-interface	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2023 11:57pm
staging-interface	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2023 11:57pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
storybook	⬜️ Ignored (Inspect)			Apr 19, 2023 11:57pm

lgtmrobo · 2023-04-18T23:15:04Z

components/modules/HomePage/DiscoverCollections.tsx

+      'minlg:before:w-40 minlg:before:absolute minlg:before:left-[2.5rem] minlg:before:top-0 minlg:before:h-[1.875rem] before:bg-white before:skew-x-[-20deg]',
+      'minlg:after:w-[8.9rem] minlg:after:absolute minlg:after:left-[11.5rem] minlg:after:top-0 minlg:after:h-[5.5rem] after:bg-white after:skew-x-[-20deg]'
+    )}>
+      <svg className='absolute left-7 top-0 minlg:hidden' width="239" height="92" viewBox="0 0 239 92" fill="white" xmlns="http://www.w3.org/2000/svg">


@ryolambert any thoughts here for optimization for this svg?

Honestly, not much room to optimize. Though preferably, this should be moved to it's own icon file public/icons/svg-name.svg, then imported as import ExSvgIcon from 'public/icons/svg-name.svg?svgr';. Unless we've got any state that's linked to directly changing the svg's styling for colors, etc.

Once the svg is in it's own separate file we can run a tool like svgo on it to minify it.

Done: own icon file

aglovlyuk · 2023-04-19T11:36:46Z

Please see comments, footer changes need to be gated until new homepage v3 goes out

footer from your PR:

Footer on Live site:

Done

lgtmrobo

@dimamankov some comments, but getting there. Also I still see a few more places where the button needs to be added ex BuildProfile.tsx. Please check all components for homepage v3

lgtmrobo · 2023-04-19T20:52:10Z

components/elements/Button.tsx

+  SECONDARY = 'SECONDARY'
+}
+export enum WebButtonSize {
+  DEFAULT = 'DEFAULT',


I don't think this is needed, isn't there only one web button size?

Check please new commit

lgtmrobo · 2023-04-19T20:52:42Z

components/elements/Button.tsx

+      switch (props.size) {
+      case WebButtonSize.DEFAULT:
+        switch(props.type) {
+        case(ButtonType.PRIMARY):


shouldn't this be WebButtonType.PRIMARY ?

Check please new commit

components/elements/Button.tsx

…e into feat/NFT-1873-animation

…at/NFT-1873-animation

lgtmrobo

Overall looks good, there are still a couple of things to fix in my opinion. There is still also a rogue tag being used in ProfileSection.tsx. If these are fixed, you should be good from my side! Thanks for the hard work

components/elements/Button.tsx

components/modules/HomePage/WhatWeCanDo.tsx

ryolambert

@dimamankov Looks good to me, let's merge and we can iterate on any hot fixes/design changes necessary. 👍

ryolambert · 2023-04-19T21:02:18Z

components/modules/HomePage/SocialSection.tsx

+                data-aos-delay="400"
              >
                <BlurImage
                  width={700}


@dimamankov Also recommend adding a drop shadow to the images to match the designs. 👍

Suggested change

width={700}

className='drop-shadow-xl'

width={700}

lgtmrobo

all clear on my end, good work

HPv3: Fixes, Pixel Perfect, Responsive

1310dd2

Merge branch 'main' into feat/NFT-1873-animation

e130d61

# Conflicts: # components/modules/HomePage/DiscoverCollections.tsx # components/modules/HomePage/HeroSection.tsx # components/modules/HomePage/SocialSection.tsx # components/modules/HomePage/WhatWeCanDo.tsx # pages/index.tsx

aglovlyuk had a problem deploying to dev April 18, 2023 21:35 — with GitHub Actions Failure

aglovlyuk had a problem deploying to sandbox April 18, 2023 21:35 — with GitHub Actions Failure

fix for conflicts

99e90b1

dimamankov had a problem deploying to dev April 18, 2023 21:55 — with GitHub Actions Failure

dimamankov had a problem deploying to sandbox April 18, 2023 21:55 — with GitHub Actions Failure

aglovlyuk requested a review from lgtmrobo April 18, 2023 21:59

lgtmrobo suggested changes Apr 18, 2023

View reviewed changes

Merge branch 'main' into feat/NFT-1873-animation

6aa0028

lgtmrobo had a problem deploying to sandbox April 18, 2023 23:02 — with GitHub Actions Failure

lgtmrobo had a problem deploying to dev April 18, 2023 23:02 — with GitHub Actions Failure

vercel bot deployed to Preview – production-interface April 18, 2023 23:07 View deployment

vercel bot deployed to Preview – staging-interface April 18, 2023 23:08 View deployment

vercel bot deployed to Preview – sandbox-interface April 18, 2023 23:09 View deployment

lgtmrobo reviewed Apr 18, 2023

View reviewed changes

aglovlyuk added 2 commits April 19, 2023 14:15

Fixes PR issues

3135a8e

Merge branch 'main' into feat/NFT-1873-animation

25f6e19

aglovlyuk had a problem deploying to dev April 19, 2023 11:35 — with GitHub Actions Failure

aglovlyuk had a problem deploying to sandbox April 19, 2023 11:35 — with GitHub Actions Failure

Merge branch 'main' into feat/NFT-1873-animation

9b957b9

aglovlyuk had a problem deploying to dev April 19, 2023 11:35 — with GitHub Actions Failure

aglovlyuk had a problem deploying to sandbox April 19, 2023 11:35 — with GitHub Actions Failure

bg image for what we can do section

3549f77

dimamankov had a problem deploying to sandbox April 19, 2023 12:11 — with GitHub Actions Failure

dimamankov had a problem deploying to dev April 19, 2023 12:11 — with GitHub Actions Failure

lgtmrobo suggested changes Apr 19, 2023

View reviewed changes

aglovlyuk and others added 2 commits April 20, 2023 00:55

Merge branch 'main' into feat/NFT-1873-animation

bcdd96c

new button component

eda9bca

dimamankov had a problem deploying to sandbox April 19, 2023 22:46 — with GitHub Actions Failure

dimamankov had a problem deploying to dev April 19, 2023 22:46 — with GitHub Actions Failure

aglovlyuk added 2 commits April 20, 2023 01:50

Update SocialSection Layout

9acb24a

Merge branch 'feat/NFT-1873-animation' of github.com:NFT-com/interfac…

53b57c1

…e into feat/NFT-1873-animation

aglovlyuk had a problem deploying to sandbox April 19, 2023 22:51 — with GitHub Actions Failure

aglovlyuk had a problem deploying to dev April 19, 2023 22:51 — with GitHub Actions Failure

Update SocialSection Layout

213ee42

aglovlyuk had a problem deploying to sandbox April 19, 2023 23:01 — with GitHub Actions Failure

aglovlyuk had a problem deploying to dev April 19, 2023 23:01 — with GitHub Actions Failure

dimamankov added 2 commits April 20, 2023 01:05

new button component

6acf4d4

Merge remote-tracking branch 'origin/feat/NFT-1873-animation' into fe…

9b08586

…at/NFT-1873-animation

dimamankov had a problem deploying to sandbox April 19, 2023 23:06 — with GitHub Actions Failure

dimamankov had a problem deploying to dev April 19, 2023 23:06 — with GitHub Actions Failure

lgtmrobo suggested changes Apr 19, 2023

View reviewed changes

components/elements/Button.tsx Outdated Show resolved Hide resolved

components/modules/HomePage/WhatWeCanDo.tsx Outdated Show resolved Hide resolved

fix: patch arrow icons

a22eaa5

ryolambert had a problem deploying to dev April 19, 2023 23:55 — with GitHub Actions Failure

ryolambert had a problem deploying to sandbox April 19, 2023 23:55 — with GitHub Actions Failure

vercel bot deployed to Preview – sandbox-interface April 19, 2023 23:57 View deployment

vercel bot deployed to Preview – staging-interface April 19, 2023 23:57 View deployment

vercel bot deployed to Preview – production-interface April 19, 2023 23:57 View deployment

fixes for PR

4b2bc65

dimamankov had a problem deploying to sandbox April 20, 2023 09:19 — with GitHub Actions Failure

dimamankov had a problem deploying to dev April 20, 2023 09:19 — with GitHub Actions Failure

ryolambert approved these changes Apr 20, 2023

View reviewed changes

lgtmrobo approved these changes Apr 20, 2023

View reviewed changes

ryolambert merged commit 46b461a into main Apr 20, 2023

ryolambert deleted the feat/NFT-1873-animation branch April 20, 2023 15:48

Conversation

aglovlyuk commented Apr 18, 2023

Describe your changes

Associated JIRA task link

Uh oh!

vercel bot commented Apr 18, 2023

Uh oh!

vercel bot commented Apr 18, 2023

Uh oh!

lgtmrobo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vercel bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgtmrobo Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aglovlyuk commented Apr 19, 2023

Uh oh!

lgtmrobo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lgtmrobo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ryolambert left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgtmrobo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel bot commented Apr 18, 2023 •

edited

Loading

lgtmrobo Apr 18, 2023 •

edited

Loading

lgtmrobo left a comment •

edited

Loading