feat: Add PostgreSQL Extension Support#5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
btree_gistfor EXCLUDE constraints,citext/hstorefor column types) by queryingpg_dependcatalog dependenciesCREATE EXTENSION IF NOT EXISTSstatements in migration output, ordered before all schema objects to satisfy dependenciesChanges
IR Layer
ir/ir.go: AddedExtensions []stringfield toIRstruct and newExtensionstruct implementingDiffSourceir/inspector.go: NewbuildExtensions()method that queriespg_catalog.pg_dependto find extensions used by constraints, classes, types, and functions in the target schema (excludesplpgsqland extension-internal objects)Diff Layer
internal/diff/diff.go: NewDiffTypeExtension, extension comparison logic inGenerateMigration(), andCREATE EXTENSION IF NOT EXISTSDDL generation at the top ofgenerateCreateSQL()Plan & Dump
internal/plan/schema_plan.go: AddedTypeExtensionto object ordering (first in dependency order)internal/dump/formatter.go: Addedextensionsdirectory to multi-file output and mapping for extension typeTests
ir/inspector_extension_test.go: Tests that empty schemas don't detect extensions, and schemas with EXCLUDE constraints correctly detectbtree_gisttestdata/diff/dependency/extension_btree_gist/: New test fixture for btree_gist extension with EXCLUDE USING gist constraintadd_pk,add_column_cross_schema_custom_typeto include expected extension output