Merged
Conversation
Contributor
|
Thanks for the heads up on this @rgknox. I am surprised I hadn't crashed this in my runs. Happy to test this across SA with my current parameter set. |
Contributor
Author
|
Regression tested on cheyenne intel, fates, all PASS: |
ckoven
reviewed
Jan 3, 2019
biogeochem/EDPatchDynamicsMod.F90
Outdated
|
|
||
| use EDParamsMod , only : ED_val_understorey_death, logging_coll_under_frac | ||
| use EDCohortDynamicsMod , only : zero_cohort, copy_cohort, terminate_cohorts | ||
| use ChecksBalancesMod , only : SiteCarbonStock |
Contributor
There was a problem hiding this comment.
seems like this isn't needed since all calls to it have been commented out?
Contributor
Author
There was a problem hiding this comment.
yeah. Maybe I should remove the comments too. I suppose there is no reason to keep them. Will update
Contributor
Author
|
all pass, cheyenne, intel, fates test suite: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This changeset adds some checks during the patch spawning routine that ensure new patches are only created, and new areas to those patches are only donated, if those areas are reasonably non-zero.
In long-term tests on cheyenne some near-zero (maybe zero) area patches were being formed, and crashing the runs. This fix prevents those crashes and numerical overflows associated with them.
Also, the lower bounds for acceptable patch sizes were tweaked to more reasonable levels.
Collaborators:
Expectation of Answer Changes:
Checklist:
Test Results:
These changes allowed a 100 year, 14pft simulation on master to complete successfully.
Standard regression tests TBD
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: