Skip to content

Bug Fixes for Serialization Messaging (NGWPC-9908)#21

Merged
idtodd merged 2 commits into
developmentfrom
idt-get-value-serialization-size
Mar 13, 2026
Merged

Bug Fixes for Serialization Messaging (NGWPC-9908)#21
idtodd merged 2 commits into
developmentfrom
idt-get-value-serialization-size

Conversation

@idtodd
Copy link
Copy Markdown

@idtodd idtodd commented Mar 10, 2026

This PR adds additional support for serialization.

Additions

  • Header information on the serialized data to store the size of the data to read. This is needed by the boost archive reader as it cannot read from a pointer with no length.

Testing

  1. Jeff Wade tested with several NGEN formulations to show saving and loading with no errors.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Copy link
Copy Markdown

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested this in AWS Workspace.

@cmaynard-ngwpc cmaynard-ngwpc self-requested a review March 12, 2026 21:43
Copy link
Copy Markdown

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the pipeline failure.

@idtodd idtodd merged commit db54ba0 into development Mar 13, 2026
@idtodd idtodd deleted the idt-get-value-serialization-size branch March 13, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants