Skip to content

Comments

RFC Channel Loss algorithm implementation#28

Merged
taddyb merged 3 commits intopi-7-NGWPC-6239from
NGWPC-6992
Aug 25, 2025
Merged

RFC Channel Loss algorithm implementation#28
taddyb merged 3 commits intopi-7-NGWPC-6239from
NGWPC-6992

Conversation

@taddyb
Copy link

@taddyb taddyb commented Aug 23, 2025

This PR is to implement the RFC Channel Loss algorithm into T-Route based on EPIC 6239

Additions

  • added the following parameters to the forcing_parameters config object

    • peadj for a scaling factor for ET loss
    • ssout for subsurface output
    • et_input_folder for the location of catchment output files from NGEN containing ET data
    • et_file_pattern to follow the qlat pattern for reading files
  • added support to read NGEN catchment files and create indexed outputs

  • created SSOUT and ELOSS values to subtract from Q in the mc_reach.pyx file

Removals

Changes

  • Most of the files added in this PR are ET files

Testing

  1. Created a new test/ folder for the UAT and integration tests

Screenshots

image

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@taddyb taddyb marked this pull request as ready for review August 24, 2025 18:27
Copy link

@quercoak quercoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@taddyb
Copy link
Author

taddyb commented Aug 25, 2025

@quercoak Thanks for the review! addressed the comments

  • adding the mapclassify version
  • removed commented out file writes

@taddyb taddyb merged commit 8cbe335 into pi-7-NGWPC-6239 Aug 25, 2025
@taddyb taddyb deleted the NGWPC-6992 branch August 25, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants