Skip to content

Include thickness-only BOTM locations#60

Merged
bdestombe merged 2 commits into
NHFLO:mainfrom
bdestombe-pwn:fix-botm-thickness-locations
Jun 26, 2026
Merged

Include thickness-only BOTM locations#60
bdestombe merged 2 commits into
NHFLO:mainfrom
bdestombe-pwn:fix-botm-thickness-locations

Conversation

@bdestombe-pwn

Copy link
Copy Markdown

Summary

  • Keep BOTM output rows for every source top or thickness location.
  • Remove the derived-bottom originality filter that dropped thickness-only locations.
  • Regenerate botm.geojson and botm_incl_source.geojson with 40,452 features.

Validation

  • python -m py_compile src\nhflodata\data\mockup\bodemlagen_pwn_2024\v2.0.0\botm\botm.py
  • uv run --no-project --with geopandas --with scipy --with pyyaml python botm.py
  • uv run --no-project --with pytest --with yamale --with yamllint --with pyyaml python -m pytest tests -q (fails on existing Windows path-separator expectation in test_mockup_folder_structure for mockup/lakes_pwn/v1.0.0)

bdestombe and others added 2 commits June 26, 2026 11:10
Update the BOTM generator to keep every source top/thickness location and regenerate the source-inclusive and lean GeoJSON outputs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add the missing repository.yaml entry for the tracked rivers_pwn mockup folder so the folder-structure CI check can pass.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bdestombe bdestombe merged commit 0e54189 into NHFLO:main Jun 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants