updated readme to add update instructions #5
Conversation
readme.md
Outdated
| - Within the validator folder run the following: | ||
| - $ mvn clean install | ||
| - $ docker build -t fhir-validator-r4 . | ||
| - $ docker tag fhir-validator-r4:latest 365027538941.dkr.ecr.eu-west-2.amazonaws.com/fhir-validator-r4:<hapi-fhir version-number> |
There was a problem hiding this comment.
Is there any risk with having these listed in a public repo?
There was a problem hiding this comment.
I agree here, publishing this isn't something that needs to be explained. Account ID's aren't considered sensitive
https://www.lastweekinaws.com/blog/are-aws-account-ids-sensitive-information/
But publishing the docker image is to do with deployment, which can be done in the background if necessary, and in that case I'd put the account ID etc in secrets
There was a problem hiding this comment.
From what KM showed us, building the docker image was done on his own machine using IntelliJ. We could create an action to do this here, which then allows us to keep the account ID in secrets and allows anyone to run the update. I dont see an issue with going the github action route, rather than documenting how to update manually?
I'll get on with that.
4 participants
No description provided.