Feature/safo6 nrl 721 seed sandbox data by sandyforresternhs · Pull Request #1140 · NHSDigital/NRLF

sandyforresternhs · 2026-02-10T09:43:52Z

Deletes all items in a DynamoDB table and reseeds the table with X (default = 2) pointers of each type for X (default is 2) custodians
The scripts have been implemented to allow for execution either locally or via the lambda
When running locally, the delete_all_table_items.py and seed_sandbox_table.py scripts can be run independently or via the orchestrator script reset_sandbox_table.py
The lambda handles the orchestration of the delete and seed scripts (index.py), so the reset_sandbox_table.py script is not required for the lambda
The lambda is deployed account-wide to dev and/or test (since we wouldn't want to reseed prod tables) and only when a table in the account has been specified for reseeding
Logs showing the lambda working successfully can be seen here
Because it's account-wide we have needed to make the lamda layers available in the a/c wide infrastructure

github-actions · 2026-02-10T09:48:44Z

💥 Something went wrong while deploying the pull request environment.
Check Output Logs

github-actions · 2026-02-12T16:15:43Z

🚀 PR environment successfully deployed.
Commit Hash: 1c7c0abbd7cb49c7aa4d6c482f6dcd6a538d0daa
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-12T16:56:15Z

🚀 PR environment successfully deployed.
Commit Hash: 3b56521bd8cc2e70e7282738b296bbdae3c011c1
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-12T17:09:25Z

🚀 PR environment successfully deployed.
Commit Hash: 5aebcd6b07f468d3817ba67175ee537d70cc1cfe
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-16T13:03:30Z

🚀 PR environment successfully deployed.
Commit Hash: b49b1af1cd98bbfdfa7726792bee19c0502b7550
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-17T11:40:11Z

🚀 PR environment successfully deployed.
Commit Hash: 679fc56f55e5b2de7520013a568ea53d2323722a
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-17T11:52:28Z

🚀 PR environment successfully deployed.
Commit Hash: f33166b75d2cae9edf6235594f9c88a7f15a3c6b
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-17T12:52:24Z

🚀 PR environment successfully deployed.
Commit Hash: 37c2c3f9cc99027a28cab4563443751c3718df98
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-17T15:34:16Z

🚀 PR environment successfully deployed.
Commit Hash: 56b0592af07503e9aab8c8dbd368ee395a0feb3d
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-17T17:16:01Z

🚀 PR environment successfully deployed.
Commit Hash: 012fa4fbf6a2a785d25f1c244be7879e01933d74
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs

This is EPIC 💪 nice work!

A few passing comments that I'd be happy to ignore.

Only one that we might need to address is the "*" wildcard used on the KMS key access for the new lambda - do we have an option to restrict that?

scripts/tests/test_delete_all_table_items.py

scripts/seed_sandbox_table.py

terraform/account-wide-infrastructure/dev/lambda__seed-sandbox.tf

mattdean3-nhs · 2026-02-19T11:08:49Z

terraform/account-wide-infrastructure/modules/seed_sandbox_lambda/eventbridge.tf

+  description = "Rule to clear and reseed sandbox data"
+  #   Set this to weekly once development and testing is complete
+  #   schedule_expression = "cron(0 2 ? * SUN *)" # 2am UTC, every Sunday
+  schedule_expression = "cron(0/15 9-17 ? * MON-FRI *)" # Every 15 minutes, 9am-5pm UTC, Monday-Friday


worth making this schedule a module var? that way we could have different schedules for dev and test if we want. Not sure if it's worth it though, up to you.

Great call, yep will do that 👍

mattdean3-nhs · 2026-02-19T11:11:03Z

terraform/account-wide-infrastructure/modules/seed_sandbox_lambda/iam.tf

+          "kms:Decrypt",
+          "kms:DescribeKey"
+        ]
+        Resource = "*"


do we have an option to restrict this to a specific key? rather than all keys?

Good catch, let's do that 👍

terraform/account-wide-infrastructure/test/lambda__seed-sandbox.tf

github-actions · 2026-02-19T16:41:10Z

🚀 PR environment successfully deployed.
Commit Hash: 1938493df29f9fd8513c7464c47733e97bbf4fe1
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-20T10:29:27Z

🚀 PR environment successfully deployed.
Commit Hash: 908c6b6832880c8c4ae7b92b2ed166d1c23bcce2
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-02-20T13:55:24Z

🚀 PR environment successfully deployed.
Commit Hash: d24e6f0333b7e49331b8e143b9f67a71c133d11a
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

sonarqubecloud · 2026-02-23T14:13:33Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-02-23T14:19:35Z

🚀 PR environment successfully deployed.
Commit Hash: a3de6e154b39a32d7fe67fa2c0abbeebad14442e
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

github-actions · 2026-03-02T14:44:57Z

🚀 PR environment successfully deployed.
Commit Hash: 8c698229b47c4dd4984a097d20e9d5b27f82db91
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

sonarqubecloud · 2026-03-02T14:46:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-02T14:56:43Z

🚀 PR environment successfully deployed.
Commit Hash: 9e9ca25682f822d84f1935e81e7b6d0b64d07ed9
URL: https://nrl721-01ba47.api.record-locator.dev.national.nhs.uk/

sandyforresternhs added 5 commits January 29, 2026 11:37

NRL-721 Create clone and delete scripts WIP

c5f0c43

NRL-721 Reseed pointer scripts and tests

8a876b3

NRL-721 Add failed attempts to output

321d709

NRL-721 Implement lambda and eventbridge

f10dba1

NRL-721 Get lambda working successfully

9dae7ae

sandyforresternhs temporarily deployed to pull-request February 10, 2026 09:44 — with GitHub Actions Inactive

sandyforresternhs had a problem deploying to pull-request February 10, 2026 09:47 — with GitHub Actions Failure

NRL-721 Make seed lambda ac wide and enable ac wide layers

1c7c0ab

sandyforresternhs temporarily deployed to pull-request February 12, 2026 16:09 — with GitHub Actions Inactive

sandyforresternhs temporarily deployed to pull-request February 12, 2026 16:12 — with GitHub Actions Inactive

sandyforresternhs temporarily deployed to pull-request February 12, 2026 16:15 — with GitHub Actions Inactive

sandyforresternhs temporarily deployed to pull-request February 12, 2026 16:17 — with GitHub Actions Inactive

sandyforresternhs had a problem deploying to account-dev February 12, 2026 16:28 — with GitHub Actions Failure

NRL-721 Add build to ac wide wf and deploy only when tables are listed

3b56521

sandyforresternhs temporarily deployed to pull-request February 12, 2026 16:48 — with GitHub Actions Inactive

sandyforresternhs temporarily deployed to pull-request February 12, 2026 16:52 — with GitHub Actions Inactive

NRL-721 Remove unused param

5aebcd6

sandyforresternhs temporarily deployed to pull-request February 12, 2026 17:02 — with GitHub Actions Inactive

sandyforresternhs temporarily deployed to pull-request February 12, 2026 17:06 — with GitHub Actions Inactive

sandyforresternhs temporarily deployed to pull-request February 12, 2026 17:09 — with GitHub Actions Inactive

sandyforresternhs temporarily deployed to pull-request February 12, 2026 17:11 — with GitHub Actions Inactive

sandyforresternhs added 2 commits February 16, 2026 17:04

NRL-721 Update readme

23331bc

NRL-721 Update readme and add handler unit tests

679fc56

Merge branch 'develop' into feature/SAFO6-NRL-721-seed-sandbox-data

f33166b

sandyforresternhs added 2 commits February 17, 2026 11:58

NRL-721 Add comment

8840201

NRL-721 Implement vars for layer filenames

37c2c3f

NRL-721 Update build artifact bucket

56b0592

NRL-721 Fixed batch write limit

012fa4f

mattdean3-nhs reviewed Feb 19, 2026

View reviewed changes

NRL-721 Lock down KMS arns to be table specific

1938493

NRL-721 Style changes

908c6b6

NRL-721 Handle missing kms key arns

d24e6f0

NRL-721 Remove classes from tests

a3de6e1

sandyforresternhs added 3 commits March 2, 2026 14:33

Merge branch 'develop' into feature/SAFO6-NRL-721-seed-sandbox-data

d2dadfd

NRL-721 Update pointer table names

8c69822

NRL-721 Correct pointer table name

9e9ca25

mattdean3-nhs approved these changes Mar 2, 2026

View reviewed changes

Conversation

sandyforresternhs commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

mattdean3-nhs left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mattdean3-nhs Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

sandyforresternhs Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

mattdean3-nhs Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

sandyforresternhs Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

sonarqubecloud bot commented Feb 23, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

sonarqubecloud bot commented Mar 2, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sandyforresternhs commented Feb 10, 2026 •

edited

Loading

mattdean3-nhs left a comment •

edited

Loading