Skip to content

[NRL-1966] Remove permissions layer from account-wide lambdas #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdean3-nhs merged 2 commits into from
Mar 5, 2026
Merged

[NRL-1966] Remove permissions layer from account-wide lambdas #1163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f1dbe3
[NRL-1996] Remove perms lambda layer from acc-wide infra deploy
mattdean3-nhs Mar 4, 2026
37fff60
[NRL-1996] Remove perms files from s3 cp in acc-wide workflow
mattdean3-nhs Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/deploy-account-wide-infra.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,6 @@ jobs:
role-to-assume: ${{ secrets.MGMT_ROLE_ARN }}
role-session-name: github-actions-ci-${{ inputs.environment }}-${{ github.run_id }}

- name: Add S3 Permissions to Lambda Layer
env:
ACCOUNT_NAME: ${{ vars.ACCOUNT_NAME }}
run: |
make get-s3-perms ENV=${ACCOUNT_NAME}

- name: Retrieve Server Certificates
env:
ACCOUNT_NAME: ${{ vars.ACCOUNT_NAME }}
Expand Down Expand Up @@ -107,7 +101,6 @@ jobs:

aws s3 cp dist/nrlf.zip s3://nhsd-nrlf--mgmt--ci-data/acc-$ACCOUNT_NAME/${{ github.run_id }}/nrlf.zip
aws s3 cp dist/dependency_layer.zip s3://nhsd-nrlf--mgmt--ci-data/acc-$ACCOUNT_NAME/${{ github.run_id }}/dependency_layer.zip
aws s3 cp dist/nrlf_permissions.zip s3://nhsd-nrlf--mgmt--ci-data/acc-$ACCOUNT_NAME/${{ github.run_id }}/nrlf_permissions.zip
aws s3 cp dist/seed_sandbox.zip s3://nhsd-nrlf--mgmt--ci-data/acc-$ACCOUNT_NAME/${{ github.run_id }}/seed_sandbox.zip

terraform-apply:
Expand Down Expand Up @@ -151,7 +144,6 @@ jobs:
mkdir -p dist
aws s3 cp s3://nhsd-nrlf--mgmt--ci-data/acc-$ACCOUNT_NAME/${{ github.run_id }}/nrlf.zip dist/nrlf.zip
aws s3 cp s3://nhsd-nrlf--mgmt--ci-data/acc-$ACCOUNT_NAME/${{ github.run_id }}/dependency_layer.zip dist/dependency_layer.zip
aws s3 cp s3://nhsd-nrlf--mgmt--ci-data/acc-$ACCOUNT_NAME/${{ github.run_id }}/nrlf_permissions.zip dist/nrlf_permissions.zip
aws s3 cp s3://nhsd-nrlf--mgmt--ci-data/acc-$ACCOUNT_NAME/${{ github.run_id }}/seed_sandbox.zip dist/seed_sandbox.zip

- name: Retrieve Server Certificates
Expand Down
1 change: 0 additions & 1 deletion terraform/account-wide-infrastructure/dev/lambda__seed-sandbox.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ module "seed_sandbox_lambda" {
layers = [
module.shared_lambda_layers.nrlf_layer_arn,
module.shared_lambda_layers.third_party_layer_arn,
module.shared_lambda_layers.nrlf_permissions_layer_arn
]

table_names = local.seed_table_names
Expand Down
8 changes: 0 additions & 8 deletions terraform/account-wide-infrastructure/modules/lambda-layers/layers.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,3 @@ resource "aws_lambda_layer_version" "third_party" {
compatible_runtimes = ["python3.12"]
description = "Third party dependencies layer (account-wide)"
}

resource "aws_lambda_layer_version" "nrlf_permissions" {
layer_name = "${var.name_prefix}--nrlf-permissions-layer"
filename = "${local.dist_dir}/${local.layer_zips.nrlf_permissions}"
source_code_hash = filebase64sha256("${local.dist_dir}/${local.layer_zips.nrlf_permissions}")
compatible_runtimes = ["python3.12"]
description = "NRLF permissions library layer (account-wide)"
}
5 changes: 0 additions & 5 deletions terraform/account-wide-infrastructure/modules/lambda-layers/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,3 @@ output "third_party_layer_arn" {
description = "ARN of the third party dependencies Lambda layer"
value = aws_lambda_layer_version.third_party.arn
}

output "nrlf_permissions_layer_arn" {
description = "ARN of the NRLF permissions Lambda layer"
value = aws_lambda_layer_version.nrlf_permissions.arn
}
1 change: 0 additions & 1 deletion terraform/account-wide-infrastructure/test/lambda__seed-sandbox.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ module "seed_sandbox_lambda" {
layers = [
module.shared_lambda_layers.nrlf_layer_arn,
module.shared_lambda_layers.third_party_layer_arn,
module.shared_lambda_layers.nrlf_permissions_layer_arn
]

table_names = local.seed_table_names
Expand Down