Skip to content

Feature/safo6 nrl 1986 enable allow all types#1168

Merged
sandyforresternhs merged 19 commits intodevelopfrom
feature/SAFO6-NRL-1986-enable-allow-all-types
Mar 12, 2026
Merged

Feature/safo6 nrl 1986 enable allow all types#1168
sandyforresternhs merged 19 commits intodevelopfrom
feature/SAFO6-NRL-1986-enable-allow-all-types

Conversation

@sandyforresternhs
Copy link
Contributor

@sandyforresternhs sandyforresternhs commented Mar 11, 2026 •
edited
Loading

  • PermissionsPolicy added to ConnectionMetadata to keep v2 permissions separate
  • Endpoints updated to factor in the new PermissionsPolicy object
  • V2 access control enabled for allow_all_types

@sandyforresternhs
NRL-1949 Add consumer & producer objects to auth store
e0f1027
@sandyforresternhs
Merge branch 'develop' into feature/SAFO6-NRL-1949-assign-pointer-typ…
1a3e838 
…e-perms-via-new-model
@sandyforresternhs
NRL-1949 Add V2 consumer pointer type feature tests
7eeb57f
@sandyforresternhs
NRL-1949 Add todo
ac060ab
@sandyforresternhs
NRL-1949 Add producer v2 WIP
e5d4edd
@sandyforresternhs
NRL-1949 V2 Producer tests for pointer type
db65883
@sandyforresternhs
NRL-1949 Tidy up client classes
dddea42
@sandyforresternhs
NRL-1949 Tidy up write permissions
833e404
@sandyforresternhs
NRL-1949 Amend comments
791f3a3
@sandyforresternhs
Merge branch 'develop' into feature/SAFO6-NRL-1949-assign-pointer-typ…
2762827 
…e-perms-via-new-model
@sandyforresternhs
NRL-1949 Address pr comments
2caf29a
@sandyforresternhs
Merge branch 'develop' into feature/SAFO6-NRL-1949-assign-pointer-typ…
c6ee2ea 
…e-perms-via-new-model
@sandyforresternhs
Merge branch 'develop' into feature/SAFO6-NRL-1949-assign-pointer-typ…
ef4922b 
…e-perms-via-new-model
@sandyforresternhs
Merge branch 'develop' into feature/SAFO6-NRL-1949-assign-pointer-typ…
5dcd0de 
…e-perms-via-new-model
@sandyforresternhs
NRL-1949 Add v2 perm policy to metadata & update producer endpoints
81ada46
@sandyforresternhs
NRL-1949 Add Update consumer endpoints with v2 permission policy
b128293
@sandyforresternhs sandyforresternhs requested a review from a team as a code owner March 11, 2026 13:43
@github-actions
Copy link

github-actions bot commented Mar 11, 2026

🚀 PR environment successfully deployed.
Commit Hash: b128293871e30476b22073359dfe12dabd49c73b
URL: https://nrl1986-01ba47.api.record-locator.dev.national.nhs.uk/

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

🚀 PR environment successfully deployed.
Commit Hash: 6eb0ae6c217d981461fe6e7eea2b4aa0db7bf31f
URL: https://nrl1986-01ba47.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs
mattdean3-nhs previously approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor

@mattdean3-nhs mattdean3-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - all looks good to me. There's a couple super minor niggles but happy to leave.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 12, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Mar 12, 2026

🚀 PR environment successfully deployed.
Commit Hash: 7ad3bb993c67425c8fa0cbf55420397e6e2cde4c
URL: https://nrl1986-01ba47.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs
mattdean3-nhs approved these changes Mar 12, 2026
View reviewed changes
Copy link
Contributor

@mattdean3-nhs mattdean3-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@sandyforresternhs sandyforresternhs merged commit a7cae09 into develop Mar 12, 2026
11 checks passed
@sandyforresternhs sandyforresternhs deleted the feature/SAFO6-NRL-1986-enable-allow-all-types branch March 12, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattdean3-nhs mattdean3-nhs mattdean3-nhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sandyforresternhs @mattdean3-nhs