HOSTED_TARGET_CONNECTION_PATH_SUFFIX passing to proxy templates#438
Merged
acarriedev merged 1 commit intoedgefrom Jun 28, 2023
Merged
HOSTED_TARGET_CONNECTION_PATH_SUFFIX passing to proxy templates#438acarriedev merged 1 commit intoedgefrom
acarriedev merged 1 commit intoedgefrom
Conversation
HOSTED_TARGET_HEALTHCHECK_SUFFIX Adds instantiation of these variables so they can be used to construct the <Path /> values within HOSTED_TARGET_CONNECTION and HOSTED_TARGET_HEALTHCHECK.
acarriedev
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
HOSTED_TARGET_CONNECTION_PATH_SUFFIXvariable is referenced for constructing the path value within theHOSTED_TARGET_CONNECTIONvariable.This variable was not instantiated from the environmental variable that holds the value that has been configured within your API-M pipelines/variables.
The same issue was affecting
HOSTED_TARGET_HEALTHCHECK_SUFFIX.This PR adds the instantiation of these values from env within template-proxies.yml.