DTOSS-9434 - Update Batch Notification Processor to use Notify#125
Merged
cameronhargreaves1-nhs merged 5 commits intomainfrom Jun 11, 2025
Merged
Conversation
cameronhargreaves1-nhs
force-pushed
the
DTOSS-9434-update-batch-notification-processor-to-use-notify
branch
from
33432d8 to
f9c4ba9
Compare
cameronhargreaves1-nhs
force-pushed
the
DTOSS-9434-update-batch-notification-processor-to-use-notify
branch
from
c5f39f4 to
ed351e8
Compare
cameronhargreaves1-nhs
changed the title
steventux
approved these changes
Jun 11, 2025
Contributor
steventux
left a comment
steventux
left a comment
There was a problem hiding this comment.
Excellent, nice and concise, good catch on renaming the environment vars for the environment.seed function, I hadn't thought of that. 🥇
cameronhargreaves1-nhs
deleted the
DTOSS-9434-update-batch-notification-processor-to-use-notify
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are moving away from using Comms Management and integrating directly with NHS Notify - the Batch Notification Processor Lambda needed updating. All references to Comms Management have been removed and replaced with direct links to NHS Notify.