Merged
Conversation
cameronhargreaves1-nhs
approved these changes
Jun 11, 2025
Contributor
cameronhargreaves1-nhs
left a comment
cameronhargreaves1-nhs
left a comment
There was a problem hiding this comment.
Looks good! Nice one that we caught this before it got any further 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Callback payloads from NHS Notify are JSON with a top level
dataproperty which has an array value. We currently expect an object value which is wrong.Changes
Fix expectations and handling of
dataproperty as an array. We suspect this will always contain one item only for BCSS but adds the ability to record statuses of multiple items in thedataarray.Mobbed/paired with @dnimmo and @cameronhargreaves1-nhs on this.