Merged
Conversation
dnimmo
approved these changes
Jul 2, 2025
steventux
force-pushed
the
add-notify-api-key
branch
from
71de614 to
606187d
Compare
Notify supplies an api key in the callback request header. This is not the same as the api key we use to authenticate via oauth.
steventux
force-pushed
the
add-notify-api-key
branch
from
606187d to
ccdcf6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We use 2 different API keys in the lambdas, these are stored in secrets manager and assigned to env vars at runtime.
OAUTH_API_KEYis the API key we use for our OAuth / JWT generationNOTIFY_API_KEYis the API key we use to verify callback requests from Notify.Changes
This PR re-adds
NOTIFY_API_KEYenv var and uses it for callback request verification.