Publish Oracle client lambda layer and enable thick client#162
Merged
Publish Oracle client lambda layer and enable thick client#162
Conversation
1452eff to
2743f04
Compare
See https://python-oracledb.readthedocs.io/en/latest/user_guide/initialization.html We use thick mode to handle encrypted db network configuration. We only use thick mode on deployed AWS environments where on prem dbs have this config.
2743f04 to
90d6020
Compare
4c77fbb to
8281fef
Compare
Includes the oracle client layer when publishing / updating lambda layers. At present this is hardcoded. We could define the ARN in json and read back from than to avoid definition in 2 places.
8281fef to
66cf840
Compare
dnimmo
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The BCSS development team have switched from an Oracle RDS instance to an On Prem instance which now has network encryption enabled.
This configuration difference won't work with Python's oracledb driver when run in the simpler Thin mode and requires us to enable Thick mode.
Thick mode needs Oracle client libraries present in the lambda layer and a different initialisation call in the Python code apparently.
Review notes
The oracle client layer was hand built and deployed to AWS via S3 to avoid inline deploy/update size limits. This step could be automated with more time but it works and won't change often so for now it's out of scope.
We also have 2 references to the oracle client layer which should be DRYed up, possibly by converting the terraform tfvars file to JSON and using jq to read into the Github deploy lambda layers workflow.