DTOSS-8991 add contract tests#82
Merged
cameronhargreaves1-nhs merged 8 commits intomainfrom May 22, 2025
Merged
Conversation
cameronhargreaves1-nhs
force-pushed
the
DTOSS-8991-add-contract-tests
branch
from
bbda5ad to
c2d5252
Compare
cameronhargreaves1-nhs
force-pushed
the
DTOSS-8991-add-contract-tests
branch
from
c2d5252 to
9f299ea
Compare
cameronhargreaves1-nhs
changed the title
steventux
reviewed
May 21, 2025
steventux
reviewed
May 21, 2025
steventux
reviewed
May 21, 2025
Contributor
steventux
left a comment
steventux
left a comment
There was a problem hiding this comment.
Looks great, well done for covering both tests in one go.
I think bringing the expected response JSON in line with the true shape of an NHS Notify response would be more accurate.
I also wonder if we could add some assertions around the headers we generate for the POST to /message/create as that's where a lot of our client logic is. Fine to do this in another PR though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds contract tests for sending batch messages and getting read messages