Consolidate communication management API modules#97
Merged
Conversation
steventux
changed the title
steventux
force-pushed
the
consolidate-comms-manager-modules
branch
2 times, most recently
from
521007c to
79f8d42
Compare
dnimmo
approved these changes
May 29, 2025
Refactor into functional style for consistency.
This adds the GET /statuses calling code into the shared module along with unit tests.
The shared communication_management module has a dependency on this.
Convert class to namedtuple
NamedTuple is immutable and slightly different to how we initialise a class, update implementation and tests to work this way.
steventux
force-pushed
the
consolidate-comms-manager-modules
branch
from
79f8d42 to
662170a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We had two different styles of python in two modules which call the same API
Changes
communication_managementmodule to functional style