Feature/smokescreen compartment 1 #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two packages to requirements.txt Started database connection
…function is passed
Changed the dropdown option value numbers in the functions to class variables.
Adding additional page object models
Added more page object models and create a few fail scenarios so the test fails with a clear error message
…m/NHSDigital/bcss-playwright into feature/smokescreen_compartment_1
1) Invitations Monitoring Page 2) Invitations Plans Page 3) Create a Plan Page
Added Organisations page POM Added bowel_cancer_screening_page_title_contains_text function on BasePage # Conflicts: # pages/base_page.py
Removed some hard coded values from tests reports page
…_page.py and moving them into utils/screening_subject_page_searcher.py Creating new POMs were necessary
Removed more hardcoded values from test_reports_page Updated test_organisations_page to use new page title function
More refactoring test_reports_page
davethepunkyone
previously approved these changes
Apr 3, 2025
Reformatting tests/test_screening_subject_search_page.py
…pointments" This reverts commit fb901e0.
|
10 tasks
Collaborator
|
Pull request #7 merged, closing this request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compartment 1 Smokescreen Tests
Context
This pr covers the addition of tests and functions required for the Compartment 1 Smokescreen Tests
Type of changes
This completes the migration of the compartment 1 tests from selenium to playwright
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.