Conversation
nhsd-jack-wainwright
left a comment
nhsd-jack-wainwright
left a comment
There was a problem hiding this comment.
LGTM 👍, just a few small comments / suggestions
| BASE_URL: "https://internal-dev.api.service.nhs.uk/${{ vars.PROXYGEN_API_NAME }}-integration" | ||
| ENV: "remote" | ||
| HOST: "internal-dev.api.service.nhs.uk" |
There was a problem hiding this comment.
I think BASE_URL and HOST values here will need to be updated to match the INT environment
| BASE_URL: "https://internal-dev.api.service.nhs.uk/${{ vars.PROXYGEN_API_NAME }}-integration" | |
| ENV: "remote" | |
| HOST: "internal-dev.api.service.nhs.uk" | |
| BASE_URL: "https://int.api.service.nhs.uk/${{ vars.PROXYGEN_API_NAME }}" | |
| ENV: "remote" | |
| HOST: "int.api.service.nhs.uk" |
| concurrency: | ||
| group: integration-environment | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
Does this block ensure that any currently running deployments are cancelled before this job starts?
| - name: Sanitize branch name | ||
| id: branch | ||
| env: | ||
| RAW_BRANCH_NAME: "${{ github.head_ref }}" |
There was a problem hiding this comment.
Is RAW_BRANCH_NAME required here? I guess currently this will always be integration anyway?
| # ---------- Handle application with int ---------- | ||
| - name: Create or update preview Lambda with int | ||
| env: | ||
| MOCK_URL: ${{ steps.names.outputs.int_url }} |
There was a problem hiding this comment.
I think MOCK_URL here can be removed?
| MTLS_CERT="${API_MTLS_CERT:-/cds/pathology/int/mtls/client1-key-public}" | ||
| MTLS_KEY="${API_MTLS_KEY:-/cds/pathology/int/mtls/client1-key-secret}" |
There was a problem hiding this comment.
Is mTLS required when accessing the INT APIM environment? Given we're including one with the Preview INT lambda I don't think there's any harm including it here but I guess we could potentially remove it form here and the preview-env INT deployment too?
| prefix: coverage | ||
|
|
||
| # ---------- Test suites ---------- | ||
| - name: "Run unit tests" |
There was a problem hiding this comment.
I don't think we need to run the tests included here and some of the will fail due to them relying on the mocks. We might want to develop some tests that run here (perhaps the acceptance tests for example), however for the moment I think we should be pretty confident that everything works functionally by the time we're creating a release.
|
|
Deployment Complete
|
2 participants
Description
Initial INT workflow
Context
Required to support onging iterative changes
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.