Skip to content

[CDAPI-90]: Update settings and credentials files#126

Merged
nhsd-rebecca-flynn merged 2 commits intomainfrom
feature/CDAPI-90v2
Apr 27, 2026
Merged

[CDAPI-90]: Update settings and credentials files#126
nhsd-rebecca-flynn merged 2 commits intomainfrom
feature/CDAPI-90v2

Conversation

@nhsd-rebecca-flynn
Copy link
Copy Markdown
Contributor

@nhsd-rebecca-flynn nhsd-rebecca-flynn commented Apr 23, 2026

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-rebecca-flynn nhsd-rebecca-flynn force-pushed the feature/CDAPI-90v2 branch 2 times, most recently from 3ad48fe to ffcb89f Compare April 23, 2026 15:42
@nhsd-rebecca-flynn nhsd-rebecca-flynn marked this pull request as ready for review April 24, 2026 08:26
@nhsd-rebecca-flynn nhsd-rebecca-flynn requested a review from a team as a code owner April 24, 2026 08:26
@nhsd-rebecca-flynn nhsd-rebecca-flynn requested a review from a team as a code owner April 24, 2026 11:18
@nhsd-rebecca-flynn nhsd-rebecca-flynn force-pushed the feature/CDAPI-90v2 branch 2 times, most recently from a994fb3 to c1cd5cf Compare April 24, 2026 12:33
Copy link
Copy Markdown
Collaborator

@nhsd-jack-wainwright nhsd-jack-wainwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, just a couple minor comments.

Comment thread .github/actions/proxy/publish-oas-spec/action.yaml
Comment thread .github/actions/proxy/configure-proxygen/action.yaml Outdated
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Deployment Complete

@nhsd-rebecca-flynn nhsd-rebecca-flynn merged commit c0ef5a7 into main Apr 27, 2026
39 checks passed
@nhsd-rebecca-flynn nhsd-rebecca-flynn deleted the feature/CDAPI-90v2 branch April 27, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants