Feature/cdapi 144

[samdasari11]

Description

Context

Type of changes

• Refactoring (non-breaking change)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would change existing functionality)
• Bug fix (non-breaking change which fixes an issue)

Checklist

• I have followed the code style of the project
• I have added tests to cover my changes
• I have updated the documentation accordingly
• This PR is a result of pair or mob programming
• Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

---

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

• I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

[williamjameswillis]

added some comments also my AI pointed out the following extras:

'The ticket explicitly requires: "Verify observability (logs, correlation IDs, traceability across systems)". No test in the IntEnvi suite checks response headers for a correlation ID (e.g. x-correlation-id). This is a direct gap against the acceptance criteria.'

There is no IntEnvi test for:

A missing Bearer token → expected HTTP 401
An invalid/expired Bearer token → expected HTTP 401

INTEGRATION.bru environment file is incomplete
environments/INTEGRATION.bru only declares secret variable names (PRIVATE_KEY_PATH, KID, PR_NUMBER, JWT_SECRET). However, Get_Auth_Token.bru uses {{APIM_ENV}} in its URL, which is not defined in the INTEGRATION environment. Running the auth token fetch against the integration environment will fail unless this is configured separately.

[samdasari11]

added some comments also my AI pointed out the following extras:

'The ticket explicitly requires: "Verify observability (logs, correlation IDs, traceability across systems)". No test in the IntEnvi suite checks response headers for a correlation ID (e.g. x-correlation-id). This is a direct gap against the acceptance criteria.'

There is no IntEnvi test for:

A missing Bearer token → expected HTTP 401 An invalid/expired Bearer token → expected HTTP 401

INTEGRATION.bru environment file is incomplete environments/INTEGRATION.bru only declares secret variable names (PRIVATE_KEY_PATH, KID, PR_NUMBER, JWT_SECRET). However, Get_Auth_Token.bru uses {{APIM_ENV}} in its URL, which is not defined in the INTEGRATION environment. Running the auth token fetch against the integration environment will fail unless this is configured separately.

Added relevant logs from Cloudwatch on the ticket.
Added tests for missing Auth token and Expired Auth token

[williamjameswillis]

re-approving after fixing the signed commit issue

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Deployment Complete

• Preview with mock:
  • URL: https://feature-cdapi-144.dev.endpoints.pathology-laboratory-reporting.national.nhs.uk — Status
    • Smoke test result: ✅ Passed (HTTP 200)
  • Proxy URL: https://internal-dev.api.service.nhs.uk/pathology-laboratory-reporting-pr-131
  • Lambda function: pr-feature-cdapi-144
• Mock endpoints:
  • URL: https://feature-cdapi-144.m.dev.endpoints.pathology-laboratory-reporting.national.nhs.uk
    • Smoke test result: ✅ Passed (HTTP 200)
  • Lambda function: mock-feature-cdapi-144
• Preview with integration:
  • URL: https://feature-cdapi-144.i.dev.endpoints.pathology-laboratory-reporting.national.nhs.uk — Status
    • Smoke test result: ✅ Passed (HTTP 200)
  • Proxy URL: https://internal-dev.api.service.nhs.uk/pathology-laboratory-reporting-pri-131
  • Lambda function: int-feature-cdapi-144