Skip to content

Feature/cdapi 18#3

Merged
nhsd-jack-wainwright merged 2 commits intomainfrom
feature/CDAPI-18
Dec 19, 2025
Merged

Feature/cdapi 18#3
nhsd-jack-wainwright merged 2 commits intomainfrom
feature/CDAPI-18

Conversation

@nhsd-jack-wainwright
Copy link
Copy Markdown
Collaborator

@nhsd-jack-wainwright nhsd-jack-wainwright commented Dec 15, 2025

Description

Changes applying the standard GitHub actions and implementing a new dev container for the Pathology API

Context

These changes setup a local development environment for use with the Pathology API as well as the introduction of the standard GitHub actions used with Clinical Data Sharing repositories.

Note these changes are expected to fail Sonar scanning as a Sonar project has not yet been setup or configured for the repository.

Type of changes

  • [] Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

DWolfsNHS
DWolfsNHS previously approved these changes Dec 15, 2025
Copy link
Copy Markdown
Contributor

@nhsd-rebecca-flynn nhsd-rebecca-flynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment thread .github/workflows/cicd-2-publish.yaml Outdated
Comment thread .github/actions/setup-python-project/action.yaml Outdated
Comment thread .github/actions/check-python-format/action.yaml Outdated
Comment thread .github/workflows/stage-1-commit.yaml
Comment thread .github/workflows/stage-2-test.yaml Outdated
Comment thread .github/workflows/stage-2-test.yaml Outdated
Comment thread .github/workflows/stage-2-test.yaml Outdated
Comment thread .github/workflows/stage-2-test.yaml Outdated
Comment thread pathology-api/tests/README.md
Copy link
Copy Markdown
Contributor

@nhsd-rebecca-flynn nhsd-rebecca-flynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extremely minor comment. LGTM

Copy link
Copy Markdown
Contributor

@nhsd-rebecca-flynn nhsd-rebecca-flynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link
Copy Markdown

@nhsd-jack-wainwright nhsd-jack-wainwright merged commit b17155c into main Dec 19, 2025
52 checks passed
@nhsd-jack-wainwright nhsd-jack-wainwright deleted the feature/CDAPI-18 branch December 19, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants