Conversation
MohammadPatelNHS
force-pushed
the
feature/CDAPI-65
branch
from
d7ef10e to
eef6569
Compare
|
Preview Lambda: |
nhsd-jack-wainwright
left a comment
nhsd-jack-wainwright
left a comment
There was a problem hiding this comment.
Looks good to me, just a couple minor comments.
| } | ||
|
|
||
| headers { | ||
| X-Request-ID: 3f99b84f-361c-4ec7-a7b4-5104ed70afd5 |
There was a problem hiding this comment.
Is it worth generating a unique UUID for each request here to aid with potential debugging?
There was a problem hiding this comment.
I wonder if it's also worth including a correlation ID here also
There was a problem hiding this comment.
I've added a script so that it autogenerates both.
I've only done it for this specific request for now since we might want to keep the UUID the same on creating a document so we can test the interaction of using the same UUID twice.
we can possibly update the scripts in the future to make it conditional if we want to update the UUIDs or not
|
Preview Lambda: |
MohammadPatelNHS
force-pushed
the
feature/CDAPI-65
branch
from
716a82e to
998ccf8
Compare
|
Preview Lambda: |
MohammadPatelNHS
force-pushed
the
feature/CDAPI-65
branch
from
998ccf8 to
ce4e067
Compare
|
Preview Lambda: |
MohammadPatelNHS
force-pushed
the
feature/CDAPI-65
branch
from
ce4e067 to
4264adc
Compare
|
Preview Lambda: |
MohammadPatelNHS
force-pushed
the
feature/CDAPI-65
branch
from
4264adc to
b178eba
Compare
|
Preview Lambda: |
|
3 participants
Description
Basic Bruno collection for interacting with the PDM API. Currently contains an endpoints to grab an authentication token, create an Observation resource and Get an Observation.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.