CDAPI-20 Add integration support to preview environment workflow#67
CDAPI-20 Add integration support to preview environment workflow#67neil-sproston merged 2 commits intomainfrom
Conversation
|
✅ Trivy gate: no Critical/High vulnerabilities. Trivy Filesystem Scan SummaryFilesystem: /tmp/artifact
✅ No vulnerabilities found. |
nhsd-jack-wainwright
left a comment
nhsd-jack-wainwright
left a comment
There was a problem hiding this comment.
Looks good to me 👍 , just a few minor comments / questions.
| MTLS_CERT="${API_MTLS_CERT:-/cds/pathology/dev/mtls/client1-key-public}" | ||
| MTLS_KEY="${API_MTLS_KEY:-/cds/pathology/dev/mtls/client1-key-secret}" | ||
| echo "Deploying preview function: $FN" | ||
| wait_for_lambda_ready() { |
There was a problem hiding this comment.
Is there a bit of duplication here with the main and mock lambda deployments? Is it worth implementing this waiting logic as part of a separate Github action that maybe accepts a function name to wait for?
There was a problem hiding this comment.
Indeed - this is the plan for the re-plumbing stage which is one of my next actions - as part of this we will be removing the preview-env functionality and placing the functionality into the main ci/cd workflow.
| echo "http_result=unexpected-status" >> "$GITHUB_OUTPUT" | ||
| exit 0 | ||
|
|
||
| - name: Smoke test int URL |
There was a problem hiding this comment.
Is there some more potential duplication here also? Perhaps these smoke test steps could be refactored to use a single shared github action?
There was a problem hiding this comment.
Indeed - this is the plan for the re-plumbing stage which is one of my next actions - as part of this we will be removing the preview-env functionality and placing the functionality into the main ci/cd workflow.
| const fn = '${{ steps.names.outputs.function_name }}' || 'not-set'; | ||
| const mock_fn = '${{ steps.names.outputs.mock_function_name }}' || 'not-set'; |
There was a problem hiding this comment.
Would we expect fn and mock_fn not to be set here?
There was a problem hiding this comment.
We would, but it is included as a defensive measure if the pipeline fails in part so as to make the comment a bit more reliable/understandable.
neil-sproston
force-pushed
the
CDAPI-20internalInt
branch
from
5c19204 to
e8d4201
Compare
|
|
Deployment Complete
|
2 participants
Description
Create an "internal-int" like environment for each preview environment.
Support dependabot runs.
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.