Skip to content

[CDAPI-125]: Ensured coverage artefact name is generated when running…#69

Merged
nhsd-jack-wainwright merged 1 commit intomainfrom
feature/CDAPI-125-coverage-fix
Mar 19, 2026
Merged

[CDAPI-125]: Ensured coverage artefact name is generated when running…#69
nhsd-jack-wainwright merged 1 commit intomainfrom
feature/CDAPI-125-coverage-fix

Conversation

@nhsd-jack-wainwright
Copy link
Copy Markdown
Collaborator

Description

Adds in step to generate coverage file name before attempting to run Sonar scanning as part of the update-sonar-statistics workflow.

Context

This change should fix code coverage reported against the main branch.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-jack-wainwright nhsd-jack-wainwright requested a review from a team as a code owner March 18, 2026 12:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 18, 2026

Trivy gate: no Critical/High vulnerabilities.

Trivy Filesystem Scan Summary

Filesystem: /tmp/artifact

Severity Count
CRITICAL 0
HIGH 0
MEDIUM 0
LOW 0
UNKNOWN 0

✅ No vulnerabilities found.

Copy link
Copy Markdown
Contributor

@nhsd-rebecca-flynn nhsd-rebecca-flynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhsd-jack-wainwright nhsd-jack-wainwright force-pushed the feature/CDAPI-125-coverage-fix branch from d7210de to ff40902 Compare March 19, 2026 10:37
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Deployment Complete

@nhsd-jack-wainwright nhsd-jack-wainwright merged commit d6815eb into main Mar 19, 2026
45 checks passed
@nhsd-jack-wainwright nhsd-jack-wainwright deleted the feature/CDAPI-125-coverage-fix branch March 19, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants