Skip to content

Feature/cdapi 125 coverage path#70

Merged
nhsd-jack-wainwright merged 1 commit intomainfrom
feature/CDAPI-125-coverage-path
Mar 19, 2026
Merged

Feature/cdapi 125 coverage path#70
nhsd-jack-wainwright merged 1 commit intomainfrom
feature/CDAPI-125-coverage-path

Conversation

@nhsd-jack-wainwright
Copy link
Copy Markdown
Collaborator

Description

Fixes the coverage path utilised for sonar analysis completed against the main branch to reference the correct path when only running unit tests.

Context

This PR provides a subsequent fix to sonar coverage when applied against main.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-jack-wainwright nhsd-jack-wainwright requested a review from a team as a code owner March 19, 2026 13:18
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 19, 2026

Trivy gate: no Critical/High vulnerabilities.

Trivy Filesystem Scan Summary

Filesystem: /tmp/artifact

Severity Count
CRITICAL 0
HIGH 0
MEDIUM 0
LOW 0
UNKNOWN 0

✅ No vulnerabilities found.

@nhsd-jack-wainwright nhsd-jack-wainwright force-pushed the feature/CDAPI-125-coverage-path branch from 71c344c to e3ecc4f Compare March 19, 2026 13:32
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Deployment Complete

Copy link
Copy Markdown
Contributor

@nhsd-rebecca-flynn nhsd-rebecca-flynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhsd-jack-wainwright nhsd-jack-wainwright merged commit 7a9dff5 into main Mar 19, 2026
45 checks passed
@nhsd-jack-wainwright nhsd-jack-wainwright deleted the feature/CDAPI-125-coverage-path branch March 19, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants