feature/CDAPI-75#8
Conversation
|
Preview Lambda: |
MohammadPatelNHS
force-pushed
the
feature/CDAPI-75
branch
from
f222993 to
cde396a
Compare
|
Preview Lambda: |
nhsd-jack-wainwright
left a comment
nhsd-jack-wainwright
left a comment
There was a problem hiding this comment.
LGTM 👍, just a couple additional minor coments
| fi \ | ||
|
|
||
| RUN apk update | ||
| && apk update \ |
There was a problem hiding this comment.
Very minor, but is it worth indenting these blocks just to highlight they are all part of the RUN statement above?
|
|
||
| RUN /.pyenv/bin/pyenv install ${PYTHON_VERSION} | ||
| RUN /.pyenv/bin/pyenv global ${PYTHON_VERSION} | ||
| && /.pyenv/bin/pyenv install ${PYTHON_VERSION} \ |
There was a problem hiding this comment.
As above, is it worth indenting these blocks to highlight that they're part of the same RUN command?
MohammadPatelNHS
force-pushed
the
feature/CDAPI-75
branch
from
cde396a to
0651a29
Compare
|
Preview Lambda: |
|
2 participants
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.