CCM-10447 Update for new failed reason codes#963
Merged
Conversation
|
This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: CCM-10447 |
simonlabarere
previously approved these changes
Aug 1, 2025
simonlabarere
approved these changes
Aug 6, 2025
Contributor
simonlabarere
left a comment
There was a problem hiding this comment.
Is this test potentially showing an issue with comms-mgr?
FAILED tests/api/message_batches/test_201_success.py::test_201_message_batch_terminal_failed_status - AssertionError: assert
None
==
'MFR_CFGV_0005'
FAILED tests/api/single_message/test_201_success.py::test_201_message_terminal_failed_status - AssertionError: assert
None
==
'MFR_CFGV_0005'
Contributor
Author
It's because it's no longer pointing to de-iaho3 and internal-dev doesn't have the changes yet. There's evidence of a successful deployment in the ticket. |
skaram-nhs
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates for new messageFailureReasonCode and channelFailureReasonCode fields returned by the get message endpoint.
Test Evidence
Test evidence added to CCM-10447.
Reviews Required
Checklist