Release v09 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

georgeRobertson wants to merge 3 commits into main from release_v09

Draft

Release v09 #108

refactor: upgrade pydantic to v2 (#107)

SonarQubeCloud / SonarCloud Code Analysis failed May 27, 2026 in 30s

Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 427 in src/dve/metadata_parser/domain_types.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w99&open=AZ5qRguU6j7Y6XsS5w99&pullRequest=108

Check warning on line 677 in src/dve/metadata_parser/domain_types.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w9_&open=AZ5qRguU6j7Y6XsS5w9_&pullRequest=108

Check warning on line 51 in src/dve/core_engine/backends/implementations/spark/spark_helpers.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgoQ6j7Y6XsS5w9y&open=AZ5qRgoQ6j7Y6XsS5w9y&pullRequest=108

Check warning on line 85 in src/dve/core_engine/validation.py

sonarqubecloud / SonarCloud Code Analysis

Fix this call; Previous type checks suggest that this expression has type BaseModel and it is not callable.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgq16j7Y6XsS5w92&open=AZ5qRgq16j7Y6XsS5w92&pullRequest=108

Check warning on line 37 in src/dve/core_engine/models.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgso6j7Y6XsS5w93&open=AZ5qRgso6j7Y6XsS5w93&pullRequest=108

Check warning on line 505 in src/dve/core_engine/message.py

sonarqubecloud / SonarCloud Code Analysis

Replace "list(...)[0]" with "next(iter(...))" to avoid materializing the entire iterable.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgs86j7Y6XsS5w96&open=AZ5qRgs86j7Y6XsS5w96&pullRequest=108

Check warning on line 145 in src/dve/core_engine/backends/utilities.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgpu6j7Y6XsS5w90&open=AZ5qRgpu6j7Y6XsS5w90&pullRequest=108

Check failure on line 57 in src/dve/metadata_parser/model_generator.py

sonarqubecloud / SonarCloud Code Analysis

Remove this unexpected named argument 'pattern'.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgun6j7Y6XsS5w-B&open=AZ5qRgun6j7Y6XsS5w-B&pullRequest=108

Check warning on line 60 in src/dve/core_engine/engine.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgqi6j7Y6XsS5w91&open=AZ5qRgqi6j7Y6XsS5w91&pullRequest=108

Check warning on line 269 in src/dve/core_engine/message.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgs86j7Y6XsS5w94&open=AZ5qRgs86j7Y6XsS5w94&pullRequest=108

Check warning on line 404 in src/dve/metadata_parser/domain_types.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w98&open=AZ5qRguU6j7Y6XsS5w98&pullRequest=108

Check warning on line 270 in src/dve/core_engine/message.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgs86j7Y6XsS5w95&open=AZ5qRgs86j7Y6XsS5w95&pullRequest=108

Check warning on line 54 in src/dve/core_engine/backends/readers/xml.py

sonarqubecloud / SonarCloud Code Analysis

Merge this if statement with the enclosing one.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRgpL6j7Y6XsS5w9z&open=AZ5qRgpL6j7Y6XsS5w9z&pullRequest=108

Check warning on line 706 in src/dve/metadata_parser/domain_types.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w-A&open=AZ5qRguU6j7Y6XsS5w-A&pullRequest=108

Check warning on line 274 in src/dve/metadata_parser/domain_types.py

sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w97&open=AZ5qRguU6j7Y6XsS5w97&pullRequest=108

Check warning on line 457 in src/dve/metadata_parser/domain_types.py

sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code.

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZ5qRguU6j7Y6XsS5w9-&open=AZ5qRguU6j7Y6XsS5w9-&pullRequest=108

View more details on SonarQubeCloud